Hi Avri, On Wed, 2019-09-11 at 10:58 +0000, Avri Altman wrote: > > > > Enable auto suspend capability in MediaTek UFS driver. > > > > Signed-off-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx> > Reviewed-by: Avri Altman <avri.altman@xxxxxxx> > > > --- > > drivers/scsi/ufs/ufs-mediatek.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > > index 0f6ff33ce52e..b7b177c6194c 100644 > > --- a/drivers/scsi/ufs/ufs-mediatek.c > > +++ b/drivers/scsi/ufs/ufs-mediatek.c > > @@ -117,6 +117,11 @@ static int ufs_mtk_setup_clocks(struct ufs_hba > > *hba, bool on, > > return ret; > > } > > > > +static void ufs_mtk_set_caps(struct ufs_hba *hba) { > > + hba->caps |= UFSHCD_CAP_RPM_AUTOSUSPEND; } > Even a one-liner deserve new line for its closing brackets The wired format is just happening the same as [PATCH v1 2/3] scsi: ufs: override auto suspend tunables for ufs It looks fine in patchwork website: https://patchwork.kernel.org/patch/11140757/ I'll try to fix it in v2. Thanks, Stanley