On Wed, Sep 04, 2019 at 02:07:39AM +0000, Damien Le Moal wrote: > OK. I will move the registration earlier in device_add_disk(), before the region > registration. > > However, I would still like to keep the queue freeze to protect against buggy > device drivers that call device_add_disk() with internal commands still going > on. I do not think that there are any such driver, but just want to avoid > problems. The queue freeze is also present for any user initiated elevator > change, so in this respect, this is not any different and should not be a big > problem. Thoughts ? I don't really see the point, but there should be no harm it either since a freeze of a non-busy queue should be fast.