On Wed, Aug 28, 2019 at 11:29:42AM +0900, Damien Le Moal wrote: > If the default elevator chosen is mq-deadline, elevator_init_mq() may > return an error if mq-deadline initialization fails, leading to > blk_mq_init_allocated_queue() returning an error, which in turn will > cause the block device initialization to fail and the device not being > exposed. > > Instead of taking such extreme measure, handle mq-deadline > initialization failures in the same manner as when mq-deadline is not > available (no module to load), that is, default to the "none" scheduler. > With this change, elevator_init_mq() return type can be changed to void. > > Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxx> > Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>