Re: [PATCH 2/3] scsi: bnx2fc: remove set but not used variables 'lport','host'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 23/08/19, 6:47 PM, "linux-scsi-owner@xxxxxxxxxxxxxxx on behalf of zhengbin" <linux-scsi-owner@xxxxxxxxxxxxxxx on behalf of zhengbin13@xxxxxxxxxx> wrote:

    Fixes gcc '-Wunused-but-set-variable' warning:
    
    drivers/scsi/bnx2fc/bnx2fc_io.c: In function bnx2fc_initiate_seq_cleanup:
    drivers/scsi/bnx2fc/bnx2fc_io.c:932:19: warning: variable lport set but not used [-Wunused-but-set-variable]
    drivers/scsi/bnx2fc/bnx2fc_io.c: In function bnx2fc_initiate_cleanup:
    drivers/scsi/bnx2fc/bnx2fc_io.c:1001:19: warning: variable lport set but not used [-Wunused-but-set-variable]
    drivers/scsi/bnx2fc/bnx2fc_io.c: In function bnx2fc_process_scsi_cmd_compl:
    drivers/scsi/bnx2fc/bnx2fc_io.c:1882:20: warning: variable host set but not used [-Wunused-but-set-variable]
    
    Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
    Signed-off-by: zhengbin <zhengbin13@xxxxxxxxxx>
    ---
     drivers/scsi/bnx2fc/bnx2fc_io.c | 7 -------
     1 file changed, 7 deletions(-)
    
    diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
    index 9e50e5b..da00ca5 100644
    --- a/drivers/scsi/bnx2fc/bnx2fc_io.c
    +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
    @@ -930,7 +930,6 @@ int bnx2fc_initiate_abts(struct bnx2fc_cmd *io_req)
     int bnx2fc_initiate_seq_cleanup(struct bnx2fc_cmd *orig_io_req, u32 offset,
     				enum fc_rctl r_ctl)
     {
    -	struct fc_lport *lport;
     	struct bnx2fc_rport *tgt = orig_io_req->tgt;
     	struct bnx2fc_interface *interface;
     	struct fcoe_port *port;
    @@ -948,7 +947,6 @@ int bnx2fc_initiate_seq_cleanup(struct bnx2fc_cmd *orig_io_req, u32 offset,
    
     	port = orig_io_req->port;
     	interface = port->priv;
    -	lport = port->lport;
    
     	cb_arg = kzalloc(sizeof(struct bnx2fc_els_cb_arg), GFP_ATOMIC);
     	if (!cb_arg) {
    @@ -999,7 +997,6 @@ int bnx2fc_initiate_seq_cleanup(struct bnx2fc_cmd *orig_io_req, u32 offset,
    
     int bnx2fc_initiate_cleanup(struct bnx2fc_cmd *io_req)
     {
    -	struct fc_lport *lport;
     	struct bnx2fc_rport *tgt = io_req->tgt;
     	struct bnx2fc_interface *interface;
     	struct fcoe_port *port;
    @@ -1015,7 +1012,6 @@ int bnx2fc_initiate_cleanup(struct bnx2fc_cmd *io_req)
    
     	port = io_req->port;
     	interface = port->priv;
    -	lport = port->lport;
    
     	cleanup_io_req = bnx2fc_elstm_alloc(tgt, BNX2FC_CLEANUP);
     	if (!cleanup_io_req) {
    @@ -1927,8 +1923,6 @@ void bnx2fc_process_scsi_cmd_compl(struct bnx2fc_cmd *io_req,
     	struct fcoe_fcp_rsp_payload *fcp_rsp;
     	struct bnx2fc_rport *tgt = io_req->tgt;
     	struct scsi_cmnd *sc_cmd;
    -	struct Scsi_Host *host;
    -
    
     	/* scsi_cmd_cmpl is called with tgt lock held */
    
    @@ -1957,7 +1951,6 @@ void bnx2fc_process_scsi_cmd_compl(struct bnx2fc_cmd *io_req,
     	/* parse fcp_rsp and obtain sense data from RQ if available */
     	bnx2fc_parse_fcp_rsp(io_req, fcp_rsp, num_rq);
    
    -	host = sc_cmd->device->host;
     	if (!sc_cmd->SCp.ptr) {
     		printk(KERN_ERR PFX "SCp.ptr is NULL\n");
     		return;
    --
    2.7.4

Hi,
Thanks for patch.

Acked-by: Saurav Kashyap <skashyap@xxxxxxxxxxx>

Thanks,
~Saurav
    
    





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux