Re: [PATCH 1/3] scsi: bnx2fc: remove set but not used variable 'fh'

[Saurav Kashyap <skashyap@xxxxxxxxxxx>]

On 23/08/19, 6:46 PM, "linux-scsi-owner@xxxxxxxxxxxxxxx on behalf of zhengbin" <linux-scsi-owner@xxxxxxxxxxxxxxx on behalf of zhengbin13@xxxxxxxxxx> wrote:

    Fixes gcc '-Wunused-but-set-variable' warning:
    
    drivers/scsi/bnx2fc/bnx2fc_fcoe.c: In function bnx2fc_rcv:
    drivers/scsi/bnx2fc/bnx2fc_fcoe.c:431:26: warning: variable fh set but not used [-Wunused-but-set-variable]
    
    Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
    Signed-off-by: zhengbin <zhengbin13@xxxxxxxxxx>
    ---
     drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 --
     1 file changed, 2 deletions(-)
    
    diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
    index 7796799..ab721ab 100644
    --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
    +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
    @@ -428,7 +428,6 @@ static int bnx2fc_rcv(struct sk_buff *skb, struct net_device *dev,
     	struct fc_lport *lport;
     	struct bnx2fc_interface *interface;
     	struct fcoe_ctlr *ctlr;
    -	struct fc_frame_header *fh;
     	struct fcoe_rcv_info *fr;
     	struct fcoe_percpu_s *bg;
     	struct sk_buff *tmp_skb;
    @@ -463,7 +462,6 @@ static int bnx2fc_rcv(struct sk_buff *skb, struct net_device *dev,
     		goto err;
    
     	skb_set_transport_header(skb, sizeof(struct fcoe_hdr));
    -	fh = (struct fc_frame_header *) skb_transport_header(skb);
    
     	fr = fcoe_dev_from_skb(skb);
     	fr->fr_dev = lport;
    --
    2.7.4

Hi,
Thanks for patch.

Acked-by: Saurav Kashyap <skashyap@xxxxxxxxxxx>

Thanks,
~Saurav