Re: [PATCH] scsi: fnic: remove redundant assignment of variable rc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Colin King <colin.king@xxxxxxxxxxxxx>
Subject: Re: [PATCH] scsi: fnic: remove redundant assignment of variable rc
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 14 Aug 2019 22:12:50 -0400
Cc: Satish Kharat <satishkh@xxxxxxxxx>, Sesidhar Baddela <sebaddel@xxxxxxxxx>, Karan Tilak Kumar <kartilak@xxxxxxxxx>, "James E . J . Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20190813132349.8720-1-colin.king@canonical.com> (Colin King's message of "Tue, 13 Aug 2019 14:23:49 +0100")
Organization: Oracle Corporation
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux)

Colin,

> Variable ret is initialized to a value that is never read and it is
> re-assigned later and immediatetly returns. Clean up the code by
> removing rc and just returning 0.

Applied to 5.4/scsi-queue. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH] scsi: fnic: remove redundant assignment of variable rc
  - From: Colin King

Prev by Date: Re: [PATCH v2 0/2] scsi: qla2xxx: fixes for FW trace/dump buffers
Next by Date: Re: [5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra
Previous by thread: RE: [PATCH] scsi: fnic: remove redundant assignment of variable rc
Next by thread: [PATCH] scsi: mvumi: fix 32 bit shift of a u32 value
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]