Re: [EXT] [PATCH v2 0/2] scsi: qla2xxx: fixes for FW trace/dump buffers

[Himanshu Madhani <hmadhani@xxxxxxxxxxx>]

Hi Martin W, 

On 8/14/19, 8:52 AM, "Martin Wilck" <Martin.Wilck@xxxxxxxx> wrote:

    External Email
    
    ----------------------------------------------------------------------
    From: Martin Wilck <mwilck@xxxxxxxx>
    
    Hi Himanshu, hi Martin,
    
    Please consider this series for merging. 
    
    The first patch of the series is a fix for a memory corruption we
    saw in a test where qla2xxx was loaded/unloaded repeatedly under
    memory pressure. The second one is a cleanup/consistency fix.
    
    Regards,
    Martin
    
    Changes in v2: rather then keeping the patches small, cleanup the
    buffer allocation code properly, following (and going beyond) Hannes'
    review suggestions for the v1 set.
    
    Martin Wilck (2):
      scsi: qla2xxx: qla2x00_alloc_fw_dump: set ha->eft
      scsi: qla2xxx: cleanup trace buffer initialization
    
     drivers/scsi/qla2xxx/qla_init.c | 218 +++++++++++++++-----------------
     drivers/scsi/qla2xxx/qla_os.c   |   1 +
     2 files changed, 102 insertions(+), 117 deletions(-)
    
    -- 
    2.22.0
    
    
Thanks for the series. We recently also observed similar issue on upstream kernel with load/unload script and I tested your series and did not see this issue. 

Tested-by: Himanshu Madhani <hmadhani@xxxxxxxxxxx>
Reviewed-by: Himanshu Madhani <hmadhani@xxxxxxxxxxx>

Thanks,
Himanshu