On Sun, 19 Nov 2006, Tejun Heo wrote: > Each high level driver uses scsi_device->timeout diffrently. > ... > Index: scsi-misc-2.6/drivers/scsi/st.c > =================================================================== > --- scsi-misc-2.6.orig/drivers/scsi/st.c > +++ scsi-misc-2.6/drivers/scsi/st.c > @@ -3986,7 +3986,8 @@ static int st_probe(struct device *dev) > tpnt->partition = 0; > tpnt->new_partition = 0; > tpnt->nbr_partitions = 0; > - tpnt->device->timeout = ST_TIMEOUT; > + if (!SDp->timeout) > + SDp->timeout = ST_TIMEOUT; I don't think this should be done. It probably makes the default timeout way too short. The error recovery with tapes takes a long time. The user can change the timeout if the default (900 seconds) seems too long (or short). I don't think there is anything in the midlevel or low-level code to set the timeout based on the device characteristics. This is left to the ULD. -- Kai - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
