On 8/13/19 10:31 PM, Martin Wilck wrote:
> From: Martin Wilck <mwilck@xxxxxxxx>
>
> In qla2x00_alloc_fw_dump(), an existing EFT buffer (e.g. from
> previous invocation of qla2x00_alloc_offload_mem()) is freed.
> The buffer is then re-allocated, but without setting the eft and
> eft_dma fields to the new values.
>
> Fixes: a28d9e4ef997 "scsi: qla2xxx: Add support for multiple fwdump
> templates/segments"
> Cc: Joe Carnuccio <joe.carnuccio@xxxxxxxxxx>
> Cc: Quinn Tran <qutran@xxxxxxxxxxx>
> Cc: Himanshu Madhani <hmadhani@xxxxxxxxxxx>
> Cc: Bart Van Assche <bvanassche@xxxxxxx>
> Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_init.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
> index 535dc21..6dd68be 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -3197,6 +3197,8 @@ qla2x00_alloc_fw_dump(scsi_qla_host_t *vha)
> ql_dbg(ql_dbg_init, vha, 0x00c3,
> "Allocated (%d KB) EFT ...\n", EFT_SIZE / 1024);
> eft_size = EFT_SIZE;
> + ha->eft_dma = tc_dma;
> + ha->eft = tc;
> }
>
> if (IS_QLA27XX(ha) || IS_QLA28XX(ha)) {
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
