On Tue, Aug 13, 2019 at 01:17:07PM +0100, Matthias Maennich wrote: > Modules using these symbols are required to explicitly import the > namespace. This patch was generated with the following steps and serves > as a reference to use the symbol namespace feature: > > 1) Define DDEFAULT_SYMBOL_NAMESPACE in the corresponding Makefile > 2) make (see warnings during modpost about missing imports) > 3) make nsdeps > > Instead of a DEFAULT_SYMBOL_NAMESPACE definition, the EXPORT_SYMBOL_NS > variants can be used to explicitly specify the namespace. The advantage > of the method used here is that newly added symbols are automatically > exported and existing ones are exported without touching their > respective EXPORT_SYMBOL macro expansion. > > Signed-off-by: Matthias Maennich <maennich@xxxxxxxxxx> > --- > drivers/usb/storage/Makefile | 2 ++ > drivers/usb/storage/alauda.c | 1 + > drivers/usb/storage/cypress_atacb.c | 1 + > drivers/usb/storage/datafab.c | 1 + > drivers/usb/storage/ene_ub6250.c | 1 + > drivers/usb/storage/freecom.c | 1 + > drivers/usb/storage/isd200.c | 1 + > drivers/usb/storage/jumpshot.c | 1 + > drivers/usb/storage/karma.c | 1 + > drivers/usb/storage/onetouch.c | 1 + > drivers/usb/storage/realtek_cr.c | 1 + > drivers/usb/storage/sddr09.c | 1 + > drivers/usb/storage/sddr55.c | 1 + > drivers/usb/storage/shuttle_usbat.c | 1 + > drivers/usb/storage/uas.c | 1 + > 15 files changed, 16 insertions(+) > > diff --git a/drivers/usb/storage/Makefile b/drivers/usb/storage/Makefile > index a67ddcbb4e24..46635fa4a340 100644 > --- a/drivers/usb/storage/Makefile > +++ b/drivers/usb/storage/Makefile > @@ -8,6 +8,8 @@ > > ccflags-y := -I $(srctree)/drivers/scsi > > +ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=USB_STORAGE Wait, we have to do this for every subsystem? I thought there was a macro we could use in the code itself for this. What changed from earlier versions, or was this always here? thanks, greg k-h
