On Mon, 2019-08-12 at 07:24 -0700, Christoph Hellwig wrote: > [note: question for the linux-spdx audience below] > > > - > > #ifdef __KERNEL__ > > extern int sg_big_buff; /* for sysctl */ > > #endif > > FYI, these __KERNEL__ ifdefs in non-uapi headers should go away. > > > > > +/* > > + * In version 3.9.01 of the sg driver, this file was spilt in two, > > with the > > + * bulk of the user space interface being placed in the file being > > included > > + * in the following line. > > + */ > > +#include <uapi/scsi/sg.h> > > Splitting uapi headers is standard practive, no need for the comment, > especially not with a meaningless driver version number. > > > diff --git a/include/uapi/scsi/sg.h b/include/uapi/scsi/sg.h > > new file mode 100644 > > index 000000000000..072b45bd732f > > --- /dev/null > > +++ b/include/uapi/scsi/sg.h > > @@ -0,0 +1,329 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > This needs the syscall noticed for uapi headers. FYI, what is our > stance of just adding that notice to headers newly moved to UAPI? > Do we need agreement from everyone who touched the file? Or just > after we started the split and SPDX annotations, as in this case > this header used to be available to user programs? It's pretty much covered by the original linux COPYING file, which contains the systemcall exception for everything. I think our intention is that this still applies globally, so things can be moved into the UAPI without additional permissions. James
