On Wed, Aug 07, 2019 at 01:42:42PM +0200, Douglas Gilbert wrote: > Since access_ok() has lost it direction (3rd) parameter there > seems to be no benefit in calling access_ok() before > __copy_{to|from}_user(). Simplify code by using the variant of > these functions that do not start with "__". Even before there was not much of a benefit. In general a normal driver should never use access_ok directly, so this looks like a good improvement. But which access_ok calls do you want to keep and why?