On Wed, Aug 07, 2019 at 01:42:33PM +0200, Douglas Gilbert wrote: > Move main entry point functions around so submission code comes > before completion code. Prior to this, the driver used the > traditional open(), close(), read(), write(), ioctl() ordering > however in this case that places completion code (i.e. > sg_read()) before submission code (i.e. sg_write()). The main > driver entry points are considered to be those named in struct > file_operations sg_fops' definition. > > Helper functions are often placed above their caller to reduce > the number of forward function declarations needed. This looks generally sensible. But can you also move the whole procfs code to the very end of the file to follow the usual pattern elsewhere and avoid the extra forward declaration?
