Martin, The firmware provided queue depth provides optimum performance in most of the cases/workloads. And this patch provides the option to the user to go with max queue_depth or with optimum queue_depth. -Chandrakanth -----Original Message----- From: Martin K. Petersen [mailto:martin.petersen@xxxxxxxxxx] Sent: Thursday, August 8, 2019 6:56 AM To: Chandrakanth Patil <chandrakanth.patil@xxxxxxxxxxxx> Cc: linux-scsi@xxxxxxxxxxxxxxx; kashyap.desai@xxxxxxxxxxxx; sumit.saxena@xxxxxxxxxxxx; kiran-kumar.kasturi@xxxxxxxxxxxx; sankar.patra@xxxxxxxxxxxx; sasikumar.pc@xxxxxxxxxxxx; shivasharan.srikanteshwara@xxxxxxxxxxxx; anand.lodnoor@xxxxxxxxxxxx Subject: Re: [PATCH] megaraid_sas: change sdev queue depth max vs optimal Chandrakanth, > This patch provides the module parameter and sysfs interface to switch > between the firmware provided (optimal) queue depth and controller > queue depth (can_queue). This smells a bit like a don't-be-broken flag. Why isn't the firmware-provided value optimal? -- Martin K. Petersen Oracle Linux Engineering