On Tue, Aug 06, 2019 at 07:19:11AM +0200, Christoph Hellwig wrote: > On Mon, Aug 05, 2019 at 10:17:51PM -0300, Marcos Paulo de Souza wrote: > > +void blk_execute_rq_nowait(struct gendisk *bd_disk, struct request *rq, > > + int at_head, rq_end_io_fn *done) > > We store a ->rq_disk in struct request, so we should also not need > that. And at_head should either become a bool, or be replaced with > a flags argument, ints used boolean are usually not a good idea. Makes sense. > > > @@ -81,7 +80,7 @@ void blk_execute_rq(struct request_queue *q, struct gendisk *bd_disk, > > And all the same argument changes that apply to blk_execute_rq_nowait > apply to blk_execute_rq as well. Thanks for the suggestions, I will send a v2 soon.
