> On Jul 29, 2019, at 6:29 AM, Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> wrote: > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings (Building: powerpc allyesconfig): > > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_adapter_info': > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:1582:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (connection_broken(vscsi)) > ^ > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:1584:2: note: here > default: > ^~~~~~~ > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_ping_response': > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:2494:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > vscsi->flags |= CLIENT_FAILED; > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:2495:2: note: here > case H_DROPPED: > ^~~~ > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:2496:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > vscsi->flags |= RESPONSE_Q_DOWN; > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:2497:2: note: here > case H_REMOTE_PARM: > ^~~~ > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> > — Reviewed-by: Bryant G. Ly <bly@xxxxxxxxxxxxxxxxxxxxx> (Previous ibmvscsis_tgt maintainer, Mike doesn’t check his linux email often and might not see this) -Bryant
