On 7/28/19 11:21 PM, Hannes Reinecke wrote:
You've just disabled the prime reason why I did implement SCSI logging;
namely to provide per-cpu buffers where messages can be printed into.
We can move to kmalloc (or even kvmalloc), but the per-cpu pointer need
to be kept.
Hi Hannes,
The approach without my patch is as follows:
* Allocate a buffer for a single line of logging output.
* Call scnprintf() or another formatting function one or more times to
produce a single line of logging output.
* Call dev_printk() to send that single line to the console.
* Free the allocated buffer.
With my patch applied that approach is retained. The only difference is
how the buffer is allocated. I don't see why the SCSI logging code would
need any per-cpu memory to avoid line splitting.
Bart.
