2019年7月27日(土) 6:22 Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>: > > Hi Akinobu, > > Thank you for the v2. I've checked and it works as expected. > > One thing is missing though - ABI documentation. > > Please add Documentation/ABI/testing/sysfs-class-led-trigger-blk > and document read, write and discard files. OK. I'll add document like below. What: /sys/class/leds/<led>/interval Date: Aug 2019 KernelVersion: 5.4 Contact: linux-leds@xxxxxxxxxxxxxxx Description: Specifies the duration of the LED blink in milliseconds. Defaults to 50 ms. What: /sys/class/leds/<led>/read Date: Aug 2019 KernelVersion: 5.4 Contact: linux-leds@xxxxxxxxxxxxxxx Description: Signal data read on the block device. If set to 0, the LED will not blink on data read. If set to 1 (default), the LED will blink for the milliseconds specified in interval to signal data read. What: /sys/class/leds/<led>/write Date: Aug 2019 KernelVersion: 5.4 Contact: linux-leds@xxxxxxxxxxxxxxx Description: Signal data written on the block device. If set to 0, the LED will not blink on data written. If set to 1 (default), the LED will blink for the milliseconds specified in interval to signal data written. What: /sys/class/leds/<led>/discard Date: Aug 2019 KernelVersion: 5.4 Contact: linux-leds@xxxxxxxxxxxxxxx Description: Signal data discarded on the block device. If set to 0, the LED will not blink on data discarded. If set to 1 (default), the LED will blink for the milliseconds specified in interval to signal data discarded.