On 19-07-23 16:57:49, Sreekanth Reddy wrote: > On Mon, Jul 15, 2019 at 11:43 AM Hannes Reinecke <hare@xxxxxxx> wrote: > > I think this is fundamentally wrong. > > ABORT_TASK is used to abort a single task, which of course has to be > > known beforehand. If you don't know the task, what exactly do you hope > > to achieve here? Aborting random I/O? > > Or, even worse, aborting I/O the driver uses internally and corrupt the > > internal workflow of the driver? > > > > We should simply disallow any ABORT TASK from userspace if the TaskMID > > is zero. And I would even argue to disabllow ABORT TASK from userspace > > completely, as the smid is never relayed to userland, and as such the > > user cannot know which task should be aborted. > > Hannes, > > This interface was added long time back in mpt2sas driver and I don't > have exact reason of adding this interface at that time. > But I know that this interface is still used by BRCM test team & few > customers only for some functionality and regression testing. Sreekanth, and Hannes, Could you please give some review points on this? Thanks,
