Jeff Garzik wrote: > I'll queue it, but let me know results from your testing regardless. I no longer see disk errors; it looks like the commands are being retried at some point in the future, as I'd expect. However, now I periodically see this: BUG: warning at drivers/ata/libata-core.c:4597/ata_qc_issue() One cause of this is that sas_ata was writing the aic94xx sequencer's version of sactive into the libata's ata_port->sactive shadow register. Since we now know that aic94xx assigns its own NCQ tags, the solution is to avoid this copy, since libata manages ata_port->sactive anyway. Unfortunately, even with that patched up I still see the message, but only about 10% as frequently as I used to. I suspect that I haven't the right locking around ata_sas_queuecmd and ata_qc_complete; I'm testing that fix overnight. --D - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
