On Mon, Jun 24, 2019 at 10:22 AM Deepak Ukey <deepak.ukey@xxxxxxxxxxxxx> wrote:
>
> Added the logic for collecting IOP log respective to event log size.
>
> Signed-off-by: Deepak Ukey <deepak.ukey@xxxxxxxxxxxxx>
> Signed-off-by: Viswas G <Viswas.G@xxxxxxxxxxxxx>
> ---
Thanks, looks fine.
Reviewed-by: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>
> drivers/scsi/pm8001/pm8001_ctl.c | 33 +++++++++++++++++----------------
> 1 file changed, 17 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
> index c7e0a42c..6b85016 100644
> --- a/drivers/scsi/pm8001/pm8001_ctl.c
> +++ b/drivers/scsi/pm8001/pm8001_ctl.c
> @@ -492,25 +492,26 @@ static ssize_t pm8001_ctl_iop_log_show(struct device *cdev,
> struct Scsi_Host *shost = class_to_shost(cdev);
> struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost);
> struct pm8001_hba_info *pm8001_ha = sha->lldd_ha;
> -#define IOP_MEMMAP(r, c) \
> - (*(u32 *)((u8*)pm8001_ha->memoryMap.region[IOP].virt_ptr + (r) * 32 \
> - + (c)))
> - int i;
> char *str = buf;
> - int max = 2;
> - for (i = 0; i < max; i++) {
> - str += sprintf(str, "0x%08x 0x%08x 0x%08x 0x%08x 0x%08x 0x%08x"
> - "0x%08x 0x%08x\n",
> - IOP_MEMMAP(i, 0),
> - IOP_MEMMAP(i, 4),
> - IOP_MEMMAP(i, 8),
> - IOP_MEMMAP(i, 12),
> - IOP_MEMMAP(i, 16),
> - IOP_MEMMAP(i, 20),
> - IOP_MEMMAP(i, 24),
> - IOP_MEMMAP(i, 28));
> + u32 read_size =
> + pm8001_ha->main_cfg_tbl.pm80xx_tbl.event_log_size / 1024;
> + static u32 start, end, count;
> + u32 max_read_times = 32;
> + u32 max_count = (read_size * 1024) / (max_read_times * 4);
> + u32 *temp = (u32 *)pm8001_ha->memoryMap.region[IOP].virt_ptr;
> +
> + if ((count % max_count) == 0) {
> + start = 0;
> + end = max_read_times;
> + count = 0;
> + } else {
> + start = end;
> + end = end + max_read_times;
> }
>
> + for (; start < end; start++)
> + str += sprintf(str, "%08x ", *(temp+start));
> + count++;
> return str - buf;
> }
> static DEVICE_ATTR(iop_log, S_IRUGO, pm8001_ctl_iop_log_show, NULL);
> --
> 1.8.5.6
>
