On Tue, Jun 25, 2019 at 12:01:24PM +1000, Finn Thain wrote: > > diff --git a/drivers/s390/scsi/zfcp_dbf.c b/drivers/s390/scsi/zfcp_dbf.c > > index dccdb41bed8c..c7129f5234f0 100644 > > --- a/drivers/s390/scsi/zfcp_dbf.c > > +++ b/drivers/s390/scsi/zfcp_dbf.c > > @@ -552,7 +552,7 @@ static u16 zfcp_dbf_san_res_cap_len_if_gpn_ft(char *tag, > > if (x % (ZFCP_FC_GPN_FT_ENT_PAGE + 1)) > > acc++; > > else > > - acc = sg_virt(++resp_entry); > > + acc = sg_virt(resp_entry = sg_next(resp_entry)); > > Shouldn't that be, > > acc = sg_virt(sg_next(resp_entry)); resp_entry needs to be updated. > > > > > last = acc->fp_flags & FC_NS_FID_LAST; > > } > > diff --git a/drivers/s390/scsi/zfcp_fc.c b/drivers/s390/scsi/zfcp_fc.c > > index b018b61bd168..5048812ce660 100644 > > --- a/drivers/s390/scsi/zfcp_fc.c > > +++ b/drivers/s390/scsi/zfcp_fc.c > > @@ -742,7 +742,7 @@ static int zfcp_fc_eval_gpn_ft(struct zfcp_fc_req *fc_req, > > if (x % (ZFCP_FC_GPN_FT_ENT_PAGE + 1)) > > acc++; > > else > > - acc = sg_virt(++sg); > > + acc = sg_virt(sg = sg_next(sg)); > > and > > acc = sg_virt(sg_next(sg)); > > ? Same with above. Thanks, Ming
