Hi Chandrakanth, url: https://github.com/0day-ci/linux/commits/Chandrakanth-Patil/megaraid_sas-driver-updates-to-07-710-06-00-rc1/20190621-003611 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> New smatch warnings: drivers/scsi/megaraid/megaraid_sas_base.c:6031 megasas_init_fw() warn: curly braces intended? Old smatch warnings: drivers/scsi/megaraid/megaraid_sas_base.c:1883 megasas_set_dynamic_target_properties() warn: if statement not indented drivers/scsi/megaraid/megaraid_sas_base.c:3445 megasas_complete_cmd() error: we previously assumed 'cmd->scmd' could be null (see line 3412) drivers/scsi/megaraid/megaraid_sas_base.c:6015 megasas_init_fw() error: we previously assumed 'fusion' could be null (see line 5914) # https://github.com/0day-ci/linux/commit/0020c0465179c06d4dac82747eeffccc59b9a6e4 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 0020c0465179c06d4dac82747eeffccc59b9a6e4 vim +6031 drivers/scsi/megaraid/megaraid_sas_base.c 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6018 /* 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6019 * Performance mode settings provided through module parameter-perf_mode will 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6020 * take affect only for: 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6021 * 1. Aero family of adapters. 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6022 * 2. When user sets module parameter- perf_mode in range of 0-2. 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6023 */ 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6024 if ((perf_mode >= MR_BALANCED_PERF_MODE) && 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6025 (perf_mode <= MR_LATENCY_PERF_MODE)) 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6026 instance->perf_mode = perf_mode; 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6027 /* 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6028 * If intr coalescing is not supported by controller FW, then IOPs 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6029 * and Balanced modes are not feasible. 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6030 */ 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 @6031 if (!intr_coalescing) This if statement is indented as if it's part of the earlier condition but the comments aren't so it's not clear what was intended. 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6032 instance->perf_mode = MR_LATENCY_PERF_MODE; 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6033 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6034 } ea76a259b5 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6035 0020c04651 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6036 if (instance->perf_mode == MR_BALANCED_PERF_MODE) ea76a259b5 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6037 instance->low_latency_index_start = ea76a259b5 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6038 MR_HIGH_IOPS_QUEUE_COUNT; ea76a259b5 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6039 else ea76a259b5 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6040 instance->low_latency_index_start = 1; ea76a259b5 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6041 ea76a259b5 drivers/scsi/megaraid/megaraid_sas_base.c Chandrakanth Patil 2019-06-20 6042 num_msix_req = num_online_cpus() + instance->low_latency_index_start; --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
