On Fri, May 31, 2019 at 08:39:04AM -0700, Bart Van Assche wrote: > On 5/30/19 7:27 PM, Ming Lei wrote: > > +static int g_host_tags = 0; > > Static variables should not be explicitly initialized to zero. OK > > > +module_param_named(host_tags, g_host_tags, int, S_IRUGO); > > +MODULE_PARM_DESC(host_tags, "All submission queues share one tags"); > ^^^^^^^^ > Did you perhaps mean "one tagset"? tagset means one set of tags, here all submission queues share one single tag space(tags), see 'struct blk_mq_tags'. thanks, Ming
