Hi Bart, I love your patch! Perhaps something to improve: [auto build test WARNING on scsi/for-next] [also build test WARNING on v5.2-rc5 next-20190620] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Bart-Van-Assche/qla2xxx-Make-qla2x00_abort_srb-again-decrease-the-sp-reference-count/20190618-094414 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> coccinelle warnings: (new ones prefixed by >>) >> drivers/scsi/qla2xxx/qla_gs.c:517:1-3: ERROR: test of a variable/field address drivers/scsi/qla2xxx/qla_gs.c:524:1-3: ERROR: test of a variable/field address vim +517 drivers/scsi/qla2xxx/qla_gs.c 511 512 static void qla2x00_async_sns_sp_free(srb_t *sp) 513 { 514 struct scsi_qla_host *vha = sp->vha; 515 struct ct_arg *ctarg = &sp->u.iocb_cmd.u.ctarg; 516 > 517 if (&ctarg->rsp) { 518 dma_free_coherent(&vha->hw->pdev->dev, 519 ctarg->rsp_allocated_size, ctarg->rsp, 520 ctarg->rsp_dma); 521 ctarg->rsp = NULL; 522 } 523 524 if (&ctarg->req) { 525 dma_free_coherent(&vha->hw->pdev->dev, 526 ctarg->req_allocated_size, ctarg->req, 527 ctarg->req_dma); 528 ctarg->req = NULL; 529 } 530 531 qla2x00_sp_free(sp); 532 } 533 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
