Re: [PATCH] qla2xxx: Fix hardlockup in abort command during driver remove.

Bart Van Assche <bvanassche@xxxxxxx> · Fri, 14 Jun 2019 13:25:19 -0700

On 6/14/19 7:36 AM, Himanshu Madhani wrote:

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 172ef21827dd..d056f5e7cf93 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -1731,8 +1731,8 @@ static void qla2x00_abort_srb(struct qla_qpair *qp, srb_t *sp, const int res,
  	     !test_bit(ABORT_ISP_ACTIVE, &vha->dpc_flags) &&
  	     !qla2x00_isp_reg_stat(ha))) {
  		sp->comp = &comp;
-		rval = ha->isp_ops->abort_command(sp);
  		spin_unlock_irqrestore(qp->qp_lock_ptr, *flags);
+		rval = ha->isp_ops->abort_command(sp);
  
  		switch (rval) {
  		case QLA_SUCCESS:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>






