On Mon, 2019-06-10 at 11:40 -0700, James Bottomley wrote: > On Mon, 2019-06-10 at 23:03 +0800, Ming Lei wrote: > > The current way isn't safe for chained sgl, so use sgl helper to > > operate sgl. > > This also isn't a chained driver. However, this driver seems to > achieve this by magic number matching, which looks unsafe. I'd really > prefer it if vmw_pvscsi.h had > > #define PVSCSI_MAX_NUM_SG_ENTRIES_PER_SEGMENT SG_ALL > > James > vmw_pvscsi appears to be definitely broken though, that's how Ming found these... -Ewan
