On Mon, 2019-06-10 at 23:03 +0800, Ming Lei wrote: > The current way isn't safe for chained sgl, so use sgl helper to > operate sgl. The advansys driver doesn't currently use a chained scatterlist. In theory it could; the if (shost->sg_tablesize > SG_ALL) { shost->sg_tablesize = SG_ALL; } At around line 11226 is what prevents it and that could be eliminated provided someone actually has the hardware to test. However, provided drivers make the correct SG_ALL or less declaration, they're entitled to treat scatterlists as fully contiguous, so there's no real justification (beyond uniformity) for making it use the chain helpers. James