On Thu, Jun 6, 2019 at 3:35 AM Jason Yan <yanaijie@xxxxxxxxxx> wrote: > > > > On 2019/6/6 0:12, John Garry wrote: > > Many times in libsas, and in LLDDs which use libsas, the check for an > > expander device is re-implemented or open coded. > > > > Use dev_is_expander() instead. We rename this from > > sas_dev_type_is_expander() to not spill so many lines in referencing. > > > > Signed-off-by: John Garry<john.garry@xxxxxxxxxx> > > Cannot agree more, > > Reviewed-by: Jason Yan <yanaijie@xxxxxxxxxx> > Looks good, thanks Jason! Reviewed-by: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>