Re: [PATCH 0/4] libfc,fcoe: cleanup fc_rport_priv usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 5, 2019 at 12:39 AM Hannes Reinecke <hare@xxxxxxx> wrote:
>
> the fcoe vn2vn code is using the 'fc_rport_priv' structure as argument to its
> internal function, but is really expecting a struct fcoe_rport to immediately
> follow this one. This is not only confusing but also an error for new compilers.
> So clean up the usage by embedding fc_rport_priv into fcoe_rport, and use the
> fcoe_rport structure wherever possible.

Thanks, this looks much better than what I tried to do mechanically
that turned into a complete mess.

But that's just from scanning the patches, obviously no deep review
(much less testing).

                        Linus



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux