On Thu, May 30, 2019 at 6:34 AM Martin K. Petersen
<martin.petersen@xxxxxxxxxx> wrote:
>
>
> Suganath,
>
> > +static u8
> > +_base_set_and_get_msix_index(struct MPT3SAS_ADAPTER *ioc, u16 smid)
> > +{
> > + struct scsiio_tracker *st;
> > +
> > + st = (smid < ioc->hi_priority_smid) ?
> > + (_get_st_from_smid(ioc, smid)) : (NULL);
>
> Please make this an if statement for clarity.
Agreed. We will post patches again with this change.
Thanks,
Sreekanth
>
> > +
> > + if (st == NULL)
> > + return _base_get_msix_index(ioc, NULL);
> > +
> > + st->msix_io = ioc->get_msix_index_for_smlio(ioc, st->scmd);
> > + return st->msix_io;
> > +}
>
> --
> Martin K. Petersen Oracle Linux Engineering
