Hi Bart, Thanks for the series. We will provide ACK after these patches have gone through our internal testing. Thanks, Himanshu > On May 29, 2019, at 1:28 PM, Bart Van Assche <bvanassche@xxxxxxx> wrote: > > Hi Martin, > > This patch series is the result of code review, inspection of the Coverity > output and actual testing. The first two patches in this series are intended > for the current release cycle (kernel v5.2) and the other 18 patches are > intended for the kernel v5.3 merge window. Please consider these patches. > > Thanks, > > Bart. > > Bart Van Assche (20): > qla2xxx: Include the <asm/unaligned.h> header file from qla_dsd.h > qla2xxx: Really fix abort handling > qla2xxx: Remove an include directive from qla_mr.c > qla2xxx: Remove a forward declaration > qla2xxx: Declare the fourth ql_dump_buffer() argument const > qla2xxx: Change the return type of qla2x00_update_ms_fdmi_iocb() into > void > qla2xxx: Reduce the scope of three local variables in > qla2xxx_queuecommand() > qla2xxx: Declare qla_tgt_cmd.cdb const > qla2xxx: Change data_dsd into an array > qla2xxx: Verify locking assumptions at runtime > qla2xxx: Reduce the number of casts in GID list code > qla2xxx: Improve Linux kernel coding style conformance > qla2xxx: Remove two superfluous if-tests > qla2xxx: Simplify qlt_lport_dump() > qla2xxx: Introduce qla2x00_els_dcmd2_free() > qla2xxx: Remove a superfluous pointer check > qla2xxx: Remove two superfluous tests > qla2xxx: Fix session lookup in qlt_abort_work() > qla2xxx: Introduce the be_id_t and le_id_t data types for FC src/dst > IDs > qla2xxx: Fix qla24xx_abort_sp_done() > > drivers/scsi/qla2xxx/qla_dbg.c | 3 +- > drivers/scsi/qla2xxx/qla_def.h | 75 ++++++++++-- > drivers/scsi/qla2xxx/qla_dfs.c | 9 +- > drivers/scsi/qla2xxx/qla_dsd.h | 2 + > drivers/scsi/qla2xxx/qla_gbl.h | 4 +- > drivers/scsi/qla2xxx/qla_gs.c | 41 +++---- > drivers/scsi/qla2xxx/qla_init.c | 42 +++---- > drivers/scsi/qla2xxx/qla_iocb.c | 44 ++++---- > drivers/scsi/qla2xxx/qla_mr.c | 1 - > drivers/scsi/qla2xxx/qla_nvme.c | 4 +- > drivers/scsi/qla2xxx/qla_nvme.h | 2 +- > drivers/scsi/qla2xxx/qla_nx.c | 10 +- > drivers/scsi/qla2xxx/qla_nx.h | 14 +-- > drivers/scsi/qla2xxx/qla_os.c | 40 ++++--- > drivers/scsi/qla2xxx/qla_target.c | 176 +++++++++++------------------ > drivers/scsi/qla2xxx/qla_target.h | 35 ++---- > drivers/scsi/qla2xxx/tcm_qla2xxx.c | 23 +--- > 17 files changed, 250 insertions(+), 275 deletions(-) > > -- > 2.22.0.rc1 >