On Sat, Nov 04, 2006 at 12:15:58PM -0800, Luben Tuikov wrote: > --- Christoph Hellwig <hch@xxxxxx> wrote: > > > scsi_send_eh_cmnd is the last user of non-sg commands currently. > > This patch switches it to a one-element SG list. Also updates the > > kerneldoc comment for scsi_send_eh_cmnd to reflect reality while we're > > at it. > > So now "use_sg" means "always yes". Yes. (Except for the no data transfer case of course) > In this case I'd suggest you rename "use_sg" to something like > "num_sg" or "num_scatter" or "num_scatter_elements" or something > to this effect. > > This will unambiguate its meaning and use. That's entirely correct and I plan to fix it. The fix will happen as part of introducing support for bidirectional commands, as we will need to use_sg/num_scatter elements in that case anyway. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
