Re: [PATCH 06/21] megaraid_sas: IRQ poll to avoid CPU hard lockups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shivasharan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on v5.1-rc6 next-20190426]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Shivasharan-S/megaraid_sas-Driver-updates/20190426-182011
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)

   drivers/scsi/megaraid/megaraid_sas_fusion.c:357:49: sparse: expression using sizeof(void)
   include/linux/slab.h:664:13: sparse: undefined identifier '__builtin_mul_overflow'
   drivers/scsi/megaraid/megaraid_sas_fusion.c:577:1: sparse: symbol 'megasas_alloc_request_fusion' was not declared. Should it be static?
   drivers/scsi/megaraid/megaraid_sas_fusion.c:658:1: sparse: symbol 'megasas_alloc_reply_fusion' was not declared. Should it be static?
   drivers/scsi/megaraid/megaraid_sas_fusion.c:842:70: sparse: incorrect type in assignment (different base types) @@    expected unsigned long long [unsigned] [usertype] RDPQBaseAddress @@    got g long [unsigned] [usertype] RDPQBaseAddress @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:851:51: sparse: incorrect type in assignment (different base types) @@    expected restricted __le64 [usertype] Words @@    got __le64 [usertype] Words @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:735:1: sparse: symbol 'megasas_alloc_rdpq_fusion' was not declared. Should it be static?
   drivers/scsi/megaraid/megaraid_sas_fusion.c:1234:29: sparse: incorrect type in assignment (different base types) @@    expected restricted __le16 [usertype] flags @@    got e] flags @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:1237:29: sparse: incorrect type in assignment (different base types) @@    expected restricted __le16 [usertype] flags @@    got e] flags @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:1337:21: sparse: incorrect type in assignment (different base types) @@    expected restricted __le16 [usertype] flags @@    got e] flags @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:1438:21: sparse: incorrect type in assignment (different base types) @@    expected restricted __le16 [usertype] flags @@    got e] flags @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:1986:27: sparse: expression using sizeof(void)
   drivers/scsi/megaraid/megaraid_sas_fusion.c:2100:31: sparse: expression using sizeof(void)
   drivers/scsi/megaraid/megaraid_sas_fusion.c:2168:34: sparse: incorrect type in assignment (different base types) @@    expected unsigned long long [unsigned] [long] [long long] [usertype] <noident> @@    got long] [long long] [usertype] <noident> @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:2173:26: sparse: incorrect type in assignment (different base types) @@    expected unsigned long long [unsigned] [long] [long long] [usertype] <noident> @@    got long] [long long] [usertype] <noident> @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3051:60: sparse: incorrect type in assignment (different base types) @@    expected restricted __le16 [usertype] virtual_disk_tgt_id @@    got unsignedrestricted __le16 [usertype] virtual_disk_tgt_id @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3056:47: sparse: incorrect type in assignment (different base types) @@    expected restricted __le16 [usertype] config_seq_num @@    got unsignedrestricted __le16 [usertype] config_seq_num @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3057:39: sparse: incorrect type in assignment (different base types) @@    expected restricted __le16 [usertype] DevHandle @@    got unsignedrestricted __le16 [usertype] DevHandle @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3264:48: sparse: incorrect type in assignment (different base types) @@    expected restricted __le16 [usertype] DevHandle @@    got unsignedrestricted __le16 [usertype] DevHandle @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3265:39: sparse: incorrect type in assignment (different base types) @@    expected restricted __le16 [usertype] DevHandle @@    got unsignedrestricted __le16 [usertype] DevHandle @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3266:35: sparse: incorrect type in assignment (different base types) @@    expected unsigned short [unsigned] [usertype] r1_alt_dev_handle @@    got  short [unsigned] [usertype] r1_alt_dev_handle @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3267:70: sparse: incorrect type in assignment (different base types) @@    expected unsigned short [unsigned] [usertype] peer_smid @@    got  short [unsigned] [usertype] peer_smid @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3269:73: sparse: incorrect type in assignment (different base types) @@    expected unsigned short [unsigned] [usertype] peer_smid @@    got  short [unsigned] [usertype] peer_smid @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3241:6: sparse: symbol 'megasas_prepare_secondRaid1_IO' was not declared. Should it be static?
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3478:29: sparse: incorrect type in assignment (different base types) @@    expected unsigned int [unsigned] [usertype] data_length @@    got ed int [unsigned] [usertype] data_length @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3506:59: sparse: cast to restricted __le32
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3387:21: sparse: cast to restricted __le16
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3393:21: sparse: incorrect type in assignment (different base types) @@    expected unsigned int [unsigned] [usertype] data_length @@    got ed int [unsigned] [usertype] data_length @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3404:37: sparse: incorrect type in assignment (different base types) @@    expected unsigned int [unsigned] [usertype] data_length @@    got ed int [unsigned] [usertype] data_length @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3410:32: sparse: cast to restricted __le32
>> drivers/scsi/megaraid/megaraid_sas_fusion.c:3600:6: sparse: symbol 'megasas_enable_irq_poll' was not declared. Should it be static?
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3617:6: sparse: symbol 'megasas_sync_irqs' was not declared. Should it be static?
   drivers/scsi/megaraid/megaraid_sas_fusion.c:4007:17: sparse: expression using sizeof(void)
   drivers/scsi/megaraid/megaraid_sas_fusion.c:4007:17: sparse: expression using sizeof(void)
   drivers/scsi/megaraid/megaraid_sas_fusion.c:4143:24: sparse: cast to restricted __le16
   drivers/scsi/megaraid/megaraid_sas_fusion.c:4123:6: sparse: symbol 'megasas_refire_mgmt_cmd' was not declared. Should it be static?
   drivers/scsi/megaraid/megaraid_sas_fusion.c:4340:32: sparse: incorrect type in assignment (different base types) @@    expected unsigned short [unsigned] [usertype] DevHandle @@    got  short [unsigned] [usertype] DevHandle @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:4342:30: sparse: incorrect type in assignment (different base types) @@    expected unsigned short [unsigned] [usertype] TaskMID @@    got  short [unsigned] [usertype] TaskMID @@
   drivers/scsi/megaraid/megaraid_sas_fusion.c:4645:25: sparse: symbol 'megasas_get_peer_instance' was not declared. Should it be static?
   drivers/scsi/megaraid/megaraid_sas_fusion.c:4944:7: sparse: symbol 'megasas_fusion_crash_dump' was not declared. Should it be static?
   include/linux/overflow.h:251:13: sparse: undefined identifier '__builtin_mul_overflow'
   include/linux/overflow.h:251:13: sparse: incorrect type in conditional
   include/linux/overflow.h:251:13:    got void
   include/linux/overflow.h:251:13: sparse: not a function <noident>
   include/linux/overflow.h:251:13: sparse: incorrect type in conditional
   include/linux/overflow.h:251:13:    got void
   include/linux/slab.h:664:13: sparse: call with no type!
   include/linux/overflow.h:251:13: sparse: call with no type!

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux