Re: [PATCH 0/6] libsas: Some minor improvements and tidy-up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16/04/2019 00:33, Martin K. Petersen wrote:

John,

This patchset introduces some minor improvements and tidy-up, including:
- fix PHY info in sysfs for PHY events
- min pathway rate programming improvement
- some other tidy-up and neatening

Applied to 5.2/scsi-queue, thanks!


Hi Martin,

Sorry for the slow response.

One thing that always bugged me is the ambiguous "ex" prefix for many
libsas log messages.And in a way, your patch #3 makes things worse by
replacing the more descriptive "Expander" with "ex". It does make things
more consistent, though.

OK, understood. Personally I prefer the brevity of "ex". However, apart from this, adding the SAS address to the log does add value.


I'd really like to see all the libsas messages be cleaned up with a
sensible prefix and a consistent format where possible.

So all libsas messages do have the "sas: " prefix, but they still can be vague/inconsistent at times.

Anyway, I'll check what can be done here.

Thanks,









[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux