Re: [PATCH 00/10] Improve qla2xxx coding style

Himanshu Madhani <hmadhani@xxxxxxxxxxx> · Mon, 15 Apr 2019 15:43:47 +0000

On 4/11/19, 2:53 PM, "linux-scsi-owner@xxxxxxxxxxxxxxx on behalf of Bart Van Assche" <linux-scsi-owner@xxxxxxxxxxxxxxx on behalf of bvanassche@xxxxxxx> wrote:

    Hi Martin,

    While preparing a few bug fixes for the qla2xxx driver I noticed several
    stylistic issues in that driver. I'm sending the patches with stylistic
    improvements ahead to avoid having to post too many patches at once (another
    20 patches will follow at a later time). Please consider these patches for
    kernel v5.2.

    Thanks,

    Bart.

    Bart Van Assche (10):
      qla2xxx: Use tabs to indent code
      qla2xxx: Leave a blank line after declarations
      qla2xxx: Fix formatting of pointer types
      qla2xxx: Insert spaces where required
      qla2xxx: Move the port_state_str[] definition from a .h to a .c file
      qla2xxx: Declare qla24xx_build_scsi_crc_2_iocbs() static
      qla2xxx: Move the <linux/io-64-nonatomic-lo-hi.h> include directive
      qla2xxx: Remove qla_tgt_cmd.data_work and qla_tgt_cmd.data_work_free
      qla2xxx: Remove two superfluous casts
      qla2xxx: Move qla2x00_set_fcport_state() from a .h into a .c file

     drivers/scsi/qla2xxx/qla_attr.c    | 15 +++++--
     drivers/scsi/qla2xxx/qla_bsg.c     |  5 +++
     drivers/scsi/qla2xxx/qla_dbg.c     |  2 +-
     drivers/scsi/qla2xxx/qla_def.h     | 10 +----
     drivers/scsi/qla2xxx/qla_dfs.c     |  3 ++
     drivers/scsi/qla2xxx/qla_gbl.h     |  5 +--
     drivers/scsi/qla2xxx/qla_gs.c      |  4 +-
     drivers/scsi/qla2xxx/qla_init.c    | 70 ++++++++++++++++++++----------
     drivers/scsi/qla2xxx/qla_inline.h  | 19 --------
     drivers/scsi/qla2xxx/qla_iocb.c    | 18 ++++----
     drivers/scsi/qla2xxx/qla_isr.c     | 15 ++++++-
     drivers/scsi/qla2xxx/qla_mbx.c     |  5 ++-
     drivers/scsi/qla2xxx/qla_mr.c      |  2 +
     drivers/scsi/qla2xxx/qla_nvme.c    |  1 +
     drivers/scsi/qla2xxx/qla_nx.c      | 13 ++++++
     drivers/scsi/qla2xxx/qla_nx.h      |  2 +-
     drivers/scsi/qla2xxx/qla_nx2.c     |  3 +-
     drivers/scsi/qla2xxx/qla_os.c      | 11 +++--
     drivers/scsi/qla2xxx/qla_sup.c     |  2 +-
     drivers/scsi/qla2xxx/qla_target.c  | 25 +++++++++--
     drivers/scsi/qla2xxx/qla_target.h  |  4 +-
     drivers/scsi/qla2xxx/tcm_qla2xxx.c |  2 -
     22 files changed, 149 insertions(+), 87 deletions(-)

    -- 
    2.21.0.196.g041f5ea1cf98

Looks Good

For the whole series

Acked-by: Himanshu Madhani <hmadhani@xxxxxxxxxxx> 