Pete Wyckoff wrote: > Initialize the conn->item list head in a connection, used for > associating it with a session, to avoid an oops if list_del happens > before the connection is bound. The oops is easy enough to > reproduce by calling CREATE_SESSION, CREATE_CONN, then DESTROY_CONN > (but no BIND_CONN) from userspace. > > Signed-off-by: Pete Wyckoff <pw@xxxxxxx> > --- > drivers/scsi/libiscsi.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c > index c542d0e..66fc239 100644 > --- a/drivers/scsi/libiscsi.c > +++ b/drivers/scsi/libiscsi.c > @@ -1477,6 +1477,7 @@ iscsi_conn_setup(struct iscsi_cls_sessio > INIT_LIST_HEAD(&conn->run_list); > INIT_LIST_HEAD(&conn->mgmt_run_list); > INIT_LIST_HEAD(&conn->xmitqueue); > + INIT_LIST_HEAD(&conn->item); > > /* initialize general immediate & non-immediate PDU commands queue */ > conn->immqueue = kfifo_alloc(session->mgmtpool_max * sizeof(void*), Thanks for the patch. We actually already fixed this by just removing that list. It was not being used for what it was originally intended and was getting in the way. The fix should be in 2.6.19-rc4 when it comes out. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
