> -----Original Message----- > From: David Laight <David.Laight@xxxxxxxxxx> > Sent: Wednesday, 10 April 2019 6:45 PM > To: 'Alastair D'Silva' <alastair@xxxxxxxxxxx>; alastair@xxxxxxxxxxx > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>; Joonas Lahtinen > <joonas.lahtinen@xxxxxxxxxxxxxxx>; Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>; > David Airlie <airlied@xxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>; Karsten Keil > <isdn@xxxxxxxxxxxxxx>; Jassi Brar <jassisinghbrar@xxxxxxxxx>; Tom Lendacky > <thomas.lendacky@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; > Jose Abreu <Jose.Abreu@xxxxxxxxxxxx>; Kalle Valo > <kvalo@xxxxxxxxxxxxxx>; Stanislaw Gruszka <sgruszka@xxxxxxxxxx>; > Benson Leung <bleung@xxxxxxxxxxxx>; Enric Balletbo i Serra > <enric.balletbo@xxxxxxxxxxxxx>; James E.J. Bottomley > <jejb@xxxxxxxxxxxxx>; Martin K. Petersen <martin.petersen@xxxxxxxxxx>; > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Alexander Viro > <viro@xxxxxxxxxxxxxxxxxx>; Petr Mladek <pmladek@xxxxxxxx>; Sergey > Senozhatsky <sergey.senozhatsky@xxxxxxxxx>; Steven Rostedt > <rostedt@xxxxxxxxxxx>; Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>; > intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; > ath10k@xxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; linux- > scsi@xxxxxxxxxxxxxxx; linux-fbdev@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxx; linux-fsdevel@xxxxxxxxxxxxxxx > Subject: RE: [PATCH 4/4] lib/hexdump.c: Allow multiple groups to be > separated by lines '|' > > From: Alastair D'Silva > > Sent: 10 April 2019 04:17 > > With the wider display format, it can become hard to identify how many > > bytes into the line you are looking at. > > > > The patch adds new flags to hex_dump_to_buffer() and > print_hex_dump() > > to print vertical lines to separate every N groups of bytes. > > > > eg. > > buf:00000000: 454d414e 43415053|4e495f45 00584544 > NAMESPAC|E_INDEX. > > buf:00000010: 00000000 00000002|00000000 00000000 ........|........ > > Ugg, that is just horrid. > It is enough to add an extra space if you really need the columns to be more > easily counted. > I did consider that, but it would be a more invasive change, as the buffer length required would differ based on the flags. > I'm not even sure that is needed if you are printing 32bit words. > OTOH 32bit words makes 64bit values really stupid on LE systems. > Bytes with extra spaces every 4 bytes is the format I prefer even for long > lines. > > Oh, and if you are using hexdump() a lot you want a version that never uses > snprintf(). > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, > MK1 1PT, UK Registration No: 1397386 (Wales) > > > --- > This email has been checked for viruses by AVG. > https://www.avg.com
