Re: [EXT] [PATCH 11/11] tcm_qla2xxx: Minimize #include directives

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4/4/19, 12:45 PM, "Bart Van Assche" <bvanassche@xxxxxxx> wrote:

    External Email
    
    ----------------------------------------------------------------------
    Only include those header files that are needed by the code in this source
    file.
    
    Cc: Himanshu Madhani <hmadhani@xxxxxxxxxxx>
    Cc: Giridhar Malavali <gmalavali@xxxxxxxxxxx>
    Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
    ---
     drivers/scsi/qla2xxx/tcm_qla2xxx.c | 7 -------
     1 file changed, 7 deletions(-)
    
    diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
    index 8a3075d17c63..013f94abe477 100644
    --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
    +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
    @@ -24,22 +24,15 @@
     
     
     #include <linux/module.h>
    -#include <linux/moduleparam.h>
     #include <linux/utsname.h>
    -#include <linux/vmalloc.h>
    -#include <linux/init.h>
     #include <linux/list.h>
     #include <linux/slab.h>
    -#include <linux/kthread.h>
     #include <linux/types.h>
     #include <linux/string.h>
     #include <linux/configfs.h>
     #include <linux/ctype.h>
     #include <asm/unaligned.h>
    -#include <scsi/scsi.h>
     #include <scsi/scsi_host.h>
    -#include <scsi/scsi_device.h>
    -#include <scsi/scsi_cmnd.h>
     #include <target/target_core_base.h>
     #include <target/target_core_fabric.h>
     
    -- 
    2.21.0.196.g041f5ea1cf98
    
    
 Thanks for the patch.

Acked-by: Himanshu Madhani <hmadhani@xxxxxxxxxxx>





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux