Re: [EXT] [PATCH 05/11] qla2xxx: Declare local symbols static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4/4/19, 12:45 PM, "Bart Van Assche" <bvanassche@xxxxxxx> wrote:

    External Email
    
    ----------------------------------------------------------------------
    This patch avoids that sparse complains that a declaration is missing.
    
    Cc: Himanshu Madhani <hmadhani@xxxxxxxxxxx>
    Cc: Giridhar Malavali <gmalavali@xxxxxxxxxxx>
    Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
    ---
     drivers/scsi/qla2xxx/qla_os.c | 4 ++--
     1 file changed, 2 insertions(+), 2 deletions(-)
    
    diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
    index dddfadc27b75..efb4b91ca768 100644
    --- a/drivers/scsi/qla2xxx/qla_os.c
    +++ b/drivers/scsi/qla2xxx/qla_os.c
    @@ -285,14 +285,14 @@ MODULE_PARM_DESC(qla2xuseresexchforels,
     		 "Reserve 1/2 of emergency exchanges for ELS.\n"
     		 " 0 (default): disabled");
     
    -int ql2xprotmask;
    +static int ql2xprotmask;
     module_param(ql2xprotmask, int, 0644);
     MODULE_PARM_DESC(ql2xprotmask,
     		 "Override DIF/DIX protection capabilities mask\n"
     		 "Default is 0 which sets protection mask based on "
     		 "capabilities reported by HBA firmware.\n");
     
    -int ql2xprotguard;
    +static int ql2xprotguard;
     module_param(ql2xprotguard, int, 0644);
     MODULE_PARM_DESC(ql2xprotguard, "Override choice of DIX checksum\n"
     		 "  0 -- Let HBA firmware decide\n"
    -- 
    2.21.0.196.g041f5ea1cf98
  

Thanks for the patch.

Acked-by: Himanshu Madhani <hmadhani@xxxxxxxxxxx>
    





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux