> On 31 Mar 2019, at 08:42, Rob Herring <robh@xxxxxxxxxx> wrote: > > On Wed, Mar 27, 2019 at 02:44:04PM +0000, Jan Kotas wrote: >> This patch adds a new compatible string description for >> CDNS UFS HCD + M31 16nm PHY. > > The phy is not a separate block? In this case PHY is controlled by some extra registers in the controller's address space, accessible via its hardware register interface. Having an extra compatible also makes it consistent with others controllers, which are already in the kernel. ufs-qcom.txt: - compatible : compatible list, contains one of the following - "qcom,ufs-phy-qmp-20nm" for 20nm ufs phy, "qcom,ufs-phy-qmp-14nm" for legacy 14nm ufs phy, "qcom,msm8996-ufs-phy-qmp-14nm" for 14nm ufs phy present on MSM8996 chipset. tc-dwc-g210-pltfrm.txt: - compatible : compatible list must contain the PHY type & version: "snps,g210-tc-6.00-20bit" "snps,g210-tc-6.00-40bit" Regards, Jan > >> >> Signed-off-by: Jan Kotas <jank@xxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/ufs/cdns,ufshc.txt | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/ufs/cdns,ufshc.txt b/Documentation/devicetree/bindings/ufs/cdns,ufshc.txt >> index a04a4989e..02347b017 100644 >> --- a/Documentation/devicetree/bindings/ufs/cdns,ufshc.txt >> +++ b/Documentation/devicetree/bindings/ufs/cdns,ufshc.txt >> @@ -5,8 +5,9 @@ Each UFS controller instance should have its own node. >> Please see the ufshcd-pltfrm.txt for a list of all available properties. >> >> Required properties: >> -- compatible : Compatible list, contains the following controller: >> - "cdns,ufshc" >> +- compatible : Compatible list, contains one of the following controllers: >> + "cdns,ufshc" - Generic CDNS HCI, >> + "cdns,ufshc-m31-16nm" - CDNS UFS HC + M31 16nm PHY >> complemented with the JEDEC version: >> "jedec,ufs-2.0" >> >> -- >> 2.15.0 >> >
