Hello Chad Dupuis,
The patch a66c6cd2a8ad: "scsi: qedf: Wait for upload and link down
processing during soft ctx reset" from Mar 26, 2019, leads to the
following static checker warning:
drivers/scsi/qedf/qedf_main.c:799 qedf_wait_for_upload()
info: ignoring unreachable code.
drivers/scsi/qedf/qedf_main.c
786 bool qedf_wait_for_upload(struct qedf_ctx *qedf)
787 {
788 struct qedf_rport *fcport = NULL;
789
790 while (1) {
791 if (atomic_read(&qedf->num_offloads))
792 QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_DISC,
793 "Waiting for all uploads to complete.\n");
794 else
795 return true;
^^^^^^^^^^^
Originally this was a break statement...
796 msleep(500);
797 }
798
--> 799 rcu_read_lock();
800 list_for_each_entry_rcu(fcport, &qedf->fcports, peers) {
801 if (fcport && test_bit(QEDF_RPORT_SESSION_READY,
802 &fcport->flags)) {
803 if (fcport->rdata)
804 QEDF_ERR(&qedf->dbg_ctx,
805 "Waiting for fcport %p portid=%06x.\n",
806 fcport, fcport->rdata->ids.port_id);
807 } else {
808 QEDF_ERR(&qedf->dbg_ctx,
809 "Waiting for fcport %p.\n", fcport);
810 }
811 }
812 rcu_read_unlock();
813 return false;
814
815 }
regards,
dan carpenter
