On Thu, 2019-03-28 at 10:09 -0700, Himanshu Madhani wrote: +AD4 From: Giridhar Malavali +ADw-gmalavali+AEA-marvell.com+AD4 +AD4 +AD4 This patch sets SCSI cmd-+AD4-result before scsi+AF8-done() is called. +AD4 +AD4 Signed-off-by: Giridhar Malavali +ADw-gmalavali+AEA-marvell.com+AD4 +AD4 Signed-off-by: Himanshu Madhani +ADw-hmadhani+AEA-marvell.com+AD4 +AD4 --- +AD4 drivers/scsi/qla2xxx/qla+AF8-os.c +AHw 3 +-- +AD4 1 file changed, 1 insertion(), 2 deletions(-) +AD4 +AD4 diff --git a/drivers/scsi/qla2xxx/qla+AF8-os.c b/drivers/scsi/qla2xxx/qla+AF8-os.c +AD4 index a58a2885fb70..34db83b6f932 100644 +AD4 --- a/drivers/scsi/qla2xxx/qla+AF8-os.c +AD4 +++b/drivers/scsi/qla2xxx/qlaosc7658 +7656qla2x00AXw-sp+AF8-compl(void +ACo-ptr, int res) +AD4 srb+AF8-t +ACo-sp +AD0 ptr+ADs +AD4 struct scsi+AF8-cmnd +ACo-cmd +AD0 GET+AF8-CMD+AF8-SP(sp)+ADs +AD4 +AD4 - cmd-+AD4-result +AD0 res+ADs +AD4 - +AD4 if (atomic+AF8-read(+ACY-sp-+AD4-ref+AF8-count) +AD0APQ 0) +AHs +AD4 ql+AF8-dbg(ql+AF8-dbg+AF8-io, sp-+AD4-vha, 0x3015, +AD4 +ACI-SP reference-count to ZERO -- sp+AD0AJQ-p cmd+AD0AJQ-p.n+ACI, +AD4 +AEAAQA -779,6 +7777qla2x00AXw-sp+AF8-compl(void +ACo-ptr, int res) +AD4 return+ADs +AD4 +AD4 sp-+AD4-free(sp)+ADs +AD4 cmd-+AD4-result +AD0 res+ADs +AD4 cmd-+AD4-scsi+AF8-done(cmd)+ADs Hi Giridhar, A patch description should not only explain what is changed but also why a change has been made. What is the reason that you want to make this change? Thanks, Bart.