Hi, On Thu, 2019-03-21 at 01:00 +0530, Mukesh Ojha wrote: > On 3/20/2019 7:54 PM, Yue Haibing wrote: > > From: YueHaibing <yuehaibing@xxxxxxxxxx> > > > > Fix sparse warnings: > > > > drivers/scsi/ufs/ufs-mediatek.c:19:6: warning: symbol 'ufs_mtk_cfg_unipro_cg' was not declared. Should it be static? > > drivers/scsi/ufs/ufs-mediatek.c:55:5: warning: symbol 'ufs_mtk_bind_mphy' was not declared. Should it be static? > > drivers/scsi/ufs/ufs-mediatek.c:342:27: warning: symbol 'ufs_mtk_of_match' was not declared. Should it be static? > > > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > > --- > > drivers/scsi/ufs/ufs-mediatek.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > > index c3b78fc..2fbb450 100644 > > --- a/drivers/scsi/ufs/ufs-mediatek.c > > +++ b/drivers/scsi/ufs/ufs-mediatek.c > > @@ -16,7 +16,7 @@ > > #include "unipro.h" > > #include "ufs-mediatek.h" > > > > -void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable) > > +static void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable) > > { > > u32 tmp; > > > > @@ -52,7 +52,7 @@ void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable) > > } > > } > > > > -int ufs_mtk_bind_mphy(struct ufs_hba *hba) > > +static int ufs_mtk_bind_mphy(struct ufs_hba *hba) > > { > > struct ufs_mtk_host *host = ufshcd_get_variant(hba); > > struct device *dev = hba->dev; > > @@ -339,7 +339,7 @@ static int ufs_mtk_remove(struct platform_device *pdev) > > return 0; > > } > > > > -const struct of_device_id ufs_mtk_of_match[] = { > > +static const struct of_device_id ufs_mtk_of_match[] = { > > { .compatible = "mediatek,mt8183-ufshci"}, > > {}, > > }; > > > Reviewed-by: Mukesh Ojha <mojha@xxxxxxxxxxxxxx> > > > Cheers, > Mukesh > Reviewed-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx> Thanks, Stanley