On 14/03/2019 11:40, Stanley Chu wrote:
> scsi: ufs: cleanup unused min_uA in struct ufs_vreg
cleanup => drop/remove/delete
> min_uA in strcut ufs_vreg is not used by any ufs
> drivers thus remove it.
Nits:
min_uA => min_uA field (?)
strcut => struct
not used by any ufs drivers => not used anywhere (?)
Why do you make your lines so short? You're allowed 72 characters.
> drivers/scsi/ufs/ufs.h | 1 -
> drivers/scsi/ufs/ufshcd-pltfrm.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
> index 7da7318eb6a6..0f23ac80bacd 100644
> --- a/drivers/scsi/ufs/ufs.h
> +++ b/drivers/scsi/ufs/ufs.h
> @@ -516,7 +516,6 @@ struct ufs_vreg {
> bool enabled;
> int min_uV;
> int max_uV;
> - int min_uA;
> int max_uA;
> };
>
> diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
> index 895a9b5ac989..588079286e8a 100644
> --- a/drivers/scsi/ufs/ufshcd-pltfrm.c
> +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
> @@ -164,7 +164,6 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name,
> goto out;
> }
>
> - vreg->min_uA = 0;
> if (!strcmp(name, "vcc")) {
> if (of_property_read_bool(np, "vcc-supply-1p8")) {
> vreg->min_uV = UFS_VREG_VCC_1P8_MIN_UV;
>
Reviewed-by: Marc Gonzalez <marc.w.gonzalez@xxxxxxx>
