Re: [PATCH] scsi: lpfc: Fix error codes in lpfc_sli4_pci_mem_setup()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/6/2019 9:33 PM, Dan Carpenter wrote:
It used to be that "error" was set to -ENODEV at the start of the
function but we shifted some code around an now "error" is set to
zero for most error paths.  There is a mix of direct returns and
"goto out" but I changed everything to direct returns for consistency.

Fixes: 56de8357049c ("scsi: lpfc: fix calls to dma_set_mask_and_coherent()")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
  drivers/scsi/lpfc/lpfc_init.c | 16 +++++++++-------
  1 file changed, 9 insertions(+), 7 deletions(-)



Reviewed-by:  James Smart  <james.smart@xxxxxxxxxxxx>

Thanks

-- james




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux