On Fri, 2019-02-22 at 17:37 +-0100, Przemek Socha wrote: +AD4 +AFs ... +AF0 +AD4 git bisect good 7cedffec8e759480f7f7a9be9cd0d7ebf0aafff2 +AD4 +ACM first bad commit: +AFs-986d413b7c156e69198dfc80fb74aa18d0ddef44+AF0 blk-mq: Enable +AD4 support for runtime power management Hi Przemek, This is weird. Neither scsi+AF8-device+AF8-quiesce() nor scsi+AF8-device+AF8-resume() are called by the runtime power management callbacks in the SCSI core. Whether or not runtime power management is enabled should not affect whether or not the warning in scsi+AF8-device+AF8-resume() is triggered. The only explanation I can think of is that a SCSI device disappeared and reappeared on the SCSI bus during the suspend/resume cycle. If that analysis is correct the easiest way to avoid that this warning appears is as follows: +AFs-PATCH+AF0 Avoid that system resume triggers a kernel warning This patch avoids that the following warning is triggered: WARNING: CPU: 2 PID: 11303 at drivers/scsi/scsi+AF8-lib.c:2600 scsi+AF8-device+AF8-resume+-0x4f/0x58 CPU: 2 PID: 11303 Comm: kworker/u8:70 Not tainted 5.0.0-rc1+- +ACM-50 Hardware name: LENOVO 80E3/Lancer 5B2, BIOS A2CN45WW(V2.13) 08/04/2016 Workqueue: events+AF8-unbound async+AF8-run+AF8-entry+AF8-fn Call Trace: scsi+AF8-dev+AF8-type+AF8-resume+-0x2e/0x60 async+AF8-run+AF8-entry+AF8-fn+-0x32/0xd8 process+AF8-one+AF8-work+-0x1f4/0x420 worker+AF8-thread+-0x28/0x3c0 kthread+-0x118/0x130 ret+AF8-from+AF8-fork+-0x22/0x40 Reported-by: Przemek Socha +ADw-soprwa+AEA-gmail.com+AD4 Fixes: 3a0a529971ec (+ACI-block, scsi: Make SCSI quiesce and resume work reliably+ACI) +ACM v4.15 Signed-off-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4 --- drivers/scsi/scsi+AF8-lib.c +AHw 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/scsi+AF8-lib.c b/drivers/scsi/scsi+AF8-lib.c index c77cb0d31dbc..c73045a5f739 100644 --- a/drivers/scsi/scsi+AF8-lib.c +-+-+- b/drivers/scsi/scsi+AF8-lib.c +AEAAQA -2541,7 +-2541,6 +AEAAQA void scsi+AF8-device+AF8-resume(struct scsi+AF8-device +ACo-sdev) +ACo device deleted during suspend) +ACo-/ mutex+AF8-lock(+ACY-sdev-+AD4-state+AF8-mutex)+ADs - WARN+AF8-ON+AF8-ONCE(+ACE-sdev-+AD4-quiesced+AF8-by)+ADs sdev-+AD4-quiesced+AF8-by +AD0 NULL+ADs blk+AF8-clear+AF8-pm+AF8-only(sdev-+AD4-request+AF8-queue)+ADs if (sdev-+AD4-sdev+AF8-state +AD0APQ SDEV+AF8-QUIESCE)
