On 22/02/2019 17:29, Lee Duncan wrote: > From: Lee Duncan <lduncan@xxxxxxxx> > > If there is an error queueing an iscsi command in > iscsi_queuecommand(), for example if the transport fails > to take the command in sessuin->tt->xmit_task(), then > the error path can call iscsi_complete_task() without > first aquiring the back_lock as required. This can > lead to things like ITT pool can get corrupt, resulting > in duplicate ITTs being sent out. > > The solution is to hold the back_lock around > iscsi_complete_task() calls, and to add a little commenting > to help others understand when back_lock must be held. You're missing a S-o-b here. Byte, Johannes -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
