Hi,
> +
> +struct ufs_mtk_dev_params {
> + u32 pwm_rx_gear; /* pwm rx gear to work in */
> + u32 pwm_tx_gear; /* pwm tx gear to work in */
> + u32 hs_rx_gear; /* hs rx gear to work in */
> + u32 hs_tx_gear; /* hs tx gear to work in */
> + u32 rx_lanes; /* number of rx lanes */
> + u32 tx_lanes; /* number of tx lanes */
> + u32 rx_pwr_pwm; /* rx pwm working pwr */
> + u32 tx_pwr_pwm; /* tx pwm working pwr */
> + u32 rx_pwr_hs; /* rx hs working pwr */
> + u32 tx_pwr_hs; /* tx hs working pwr */
> + u32 hs_rate; /* rate A/B to work in HS */
> + u32 desired_working_mode;
> +};
As this is essentially identical to ufs_qcom_dev_params and ufs_hisi_dev_params etc.,
Maybe move it to ufshcd-platform.h in a short preparatory patch, so it can be reused?
Also, the vast majority of the code in these platform-dependent modules is pretty much the same.
I wonder if it can be shape to fit some standard form?
But this is out of scope of your series.
> +/*
> + * PHY Adpater attributes
> + */
> +#define PA_LOCALTXLCCENABLE 0x155E
Already in unipro.h
Thanks,
Avri
