On Mon, Feb 18, 2019 at 8:58 AM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
>
> On Fri, Feb 15, 2019 at 6:35 PM Nathan Chancellor
> <natechancellor@xxxxxxxxx> wrote:
> >
> > On Fri, Feb 15, 2019 at 01:19:20PM +0100, Hannes Reinecke wrote:
> > > From: Sedat Dilek <sedat.dilek@xxxxxxxxx>
> > >
> > > commit 1917d42d14b7 ("fcoe: use enum for fip_mode") introduces a separate
> > > enum for the fip_mode that shall be used during initialisation handling
> > > until it is passed to fcoe_ctrl_link_up to set the initial fip_state.
> > > That change was incomplete and gcc quietly converted in various places
> > > between the fip_mode and the fip_state enum values with implicit enum
> > > conversions, which fortunately cannot cause any issues in the actual
> > > code's execution.
> > >
> > > clang however warns about these implicit enum conversions in the scsi
> > > drivers. This commit consolidates the use of the two enums, guided by
> > > clang's enum-conversion warnings.
> > >
> > > This commit now completes the use of the fip_mode:
> > > It expects and uses fip_mode in {bnx2fc,fcoe}_interface_create and
> > > fcoe_ctlr_init, and it calls fcoe_ctrl_set_set() with the correct
> > > values in fcoe_ctlr_link_up().
> > > It also breaks the association between FIP_MODE_AUTO and FIP_ST_AUTO
> > > to indicate these two enums are distinct.
> > >
> > > Link: https://github.com/ClangBuiltLinux/linux/issues/151
> > > Fixes: 1917d42d14b7 ("fcoe: use enum for fip_mode")
> > > Reported-by: Dmitry Golovin "Twisted Pair in my Hair" <dima@xxxxxxxxxx>
> > > CC: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
> > > CC: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> > > CC: Nathan Chancellor <natechancellor@xxxxxxxxx>
> > > Suggested-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
> > > Signed-off-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
> > > Signed-off-by: Hannes Reinecke <hare@xxxxxxxx>
> >
> > Reviewed-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> > Tested-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> >
> > As a side note, I think Lukas deserves a little more credit than just a
> > CC, most of the commit message wording and patch content is his. At the
> > least, a link to the original patch:
> >
> > https://lore.kernel.org/lkml/20190112053427.35696-1-lukas.bulwahn@xxxxxxxxx/
> >
>
> Hi,
>
> I had a laptop-free weekend and answering now.
>
> Of course Lukas deserves his credits for his initial work.
>
> In [1] had all references - guess it got lost when the patch was applied.
>
> AFAICS the patch has changed and whatever Hannes thinks it's OK to do.
> Hope it gets pushed soon.
>
> For me, dealing with FCOE revealed a reproducible compiler-crash and
> was a good test-case if the llvm-toolchain is fine.
>
> Thanks to all involved people.
>
> Best Regards,
> - Sedat -
>
>
> [1] https://marc.info/?l=linux-scsi&m=154990531419036&w=2
>
> > Cheers,
> > Nathan
[ ... ]
Now, I remember what went wrong.
I have sent this patch proposal from my notebook at work with its Git
setup (company's email-address).
To receive it and all answers to my private email-adresss I had added
the "From: ..." line.
Of course, the text in the commit message should have been embedded
with "Lukas Bulwahn writes: ...".
I will look how to switch easily my Git setup here.
So, my apologies.
- Sedat -
